Critique my HW 3.8 Sudoku solution

0

I see that Peter goes through each column and row for every single digit. My idea is to take every row and every column as a separate list, sort them, and check if the digits go from 1 to n. Please comment on the efficiency / correctness of my solution (it's judged correct by the system).

def check (ls):
    a = []
    a.extend(ls)
    a.sort()
    k = 1
    for l in a:
        if not l==k:
            return False
        k = k + 1
    return True

def check_sudoku(ls):
    n = len(ls)
    for l in ls:
        if not check(l):
            return False
    for i in range(n):
        a = []
        for j in range(n):
            a.append(ls[j][i])
        if not check(a):
            return False
    return True

asked 14 Mar '12, 18:42

Bo%20Tian's gravatar image

Bo Tian
49●8
accept rate: 0%

One Answer:
1

I guess I don't understand why you need to sort the lists in order to check them. I realize it's computationally insignificant for what we're doing, but you can just run a for loop over the range of the length of the list and check that the number is there.

link

answered 14 Mar '12, 18:47

David%20Harris's gravatar image

David Harris
8.1k●21●55●111
Your answer
Question text:

Markdown Basics

  • *italic* or _italic_
  • **bold** or __bold__
  • link:[text](http://url.com/ "Title")
  • image?![alt text](/path/img.jpg "Title")
  • numbered list: 1. Foo 2. Bar
  • to add a line break simply add two spaces to where you would like the new line to be.
  • basic HTML tags are also supported

learn more about Markdown

Tags:

×15,242
×161

Asked: 14 Mar '12, 18:42

Seen: 136 times

Last updated: 14 Mar '12, 18:47

Related questions

Solutions to 7.8 - Same structure

Can someone explains to me what's wrong with my solution to HW4.6?

Solution in One Line to HW5.6

Solution to 1.8 and 1.9 (find2 and rounding number)

hw3.6 - instuctor's solution possible issue

Solution for max depth (Homework 3.7) Too simple to be correct?

why use that solution if this is much shorter...

My Very Long, Non-Levenshtein Final Double Star Answer

7.1 starred - simple solution that passed tests but robots say: 'incorrect' :/

Crazy or acceptable? Finalexam 7.8