|
If the very last line of the code is a comment, it will bug out the grader. Try it. Many of us had a last line print test statements commented out. The following example will yield "Incorrect. Your procedure did not return the correct value." on submit. Remove the last comment or add an empty line after the comment and it will be marked correct. example from HW3.3: |
|
We spent the last two hours looking at the cases that cause this to be graded wrong. You have one of them. There are other weird things (like if you added a statement before that comment) and we are working to track down the source of the problem.... nice to know you are on the case so quick I figured this was being looked into, and I thank you for keeping us posted on a bit of the progress. Thanks Peter. Yeah it seems like white space on the last line is also causing problems. Were you adding a new line after importing our code in the previous homeworks? This seems to just be a problem with HW3. Thanks for looking in to this! 1
It seems like it's a missing newline - http://www.udacity-forums.com/cs101/questions/35766/can-you-fix-the-auto-grader-to-deal-with-a-missing-newline-at-the-end-of-the-file 1
i got all my coding questions graded correctly. I just don't put in comments and add like 2-3 blank lines after the code. I clear the tab at the next line after the procedure is done You need to fix this! 7
It turns out that it was a bug in Python 2.6.6. We'll have to upgrade all our servers to 2.7 and regrade EVERYTHING. My program runs fine. But on submitting it just gives a "Incorrect. Your submission did not terminate." I removed all my print statements and resubmitted but that did not solve the problem. However, it runs fine and gives the correct answers. ouch! I wonder why we didn't see it in HW2. Thanks for all the time you've put into tracking down this bug, @PeterUdacity and all the others. Wonderful, @PeterUdacity, thanks for the vigilance!! Interesting. Maybe there should be a class requirement on the version of python that everyone should be using when they are running locally as well. Udacity would also run that version of python, so for people following the requirements, the python versions would be 100% synced up for the duration of the class. PeterUdacity if we can help in any way, let us know... once again, that's what we're here for... helping this great idea become better. Thanks for taking the time to look into this. I'm a lot happier now. :D
showing 10 of 14
show 4 more comments
|
|
I too had commented lines at the end of my code on 3.7 and 3.8. Once removed and upon re-submitting, my solutions were graded correct. I'm a bit frustrated that this has happened, and am sad to have those graded wrong despite my many hours of checking and re-checking to ensure that they were correct. That said, I am glad to know that they were indeed correct, and am proud that I was able to get them right (even though they were graded wrong). |
|
Just deleted the last line from homework exercises graded incorrect, and sure enough, now they are correct. Well, at least I will not spend the night by pointless debugging, thanks :-) |
|
Thanks for the post! I just uncommented my "print function()" test cases in 3.3, 3.5, and 3.8 and they came back correct. My solution for 3.3 was an exact match for the answer and marked incorrect. It was driving me crazy. Great course, don't mind putting in the time, but this grading was very deflating. |
|
My 3.8 was graded incorrect and I had a comment at the end. Deleting the comment made my submission correct, but the grade will remain incorrect of course. |
|
I had a left tab after the code and it was graded incorrect. If I remove the last empty line, it is graded as correct. |
|
same thing here. i left single line comments at the end of my code which caused it to be graded incorrectly. thought i was going nuts with so many missed points. anyway, now i know. hopefully they will be corrected. |
As tmcguire pointed out, it's not just comments. A tab in the very last line will give the following response on submit: "Incorrect. Your submission did not terminate."
I seems like the grade code may be missing a carriage return before appending code.
I should also note that this didn't appear to be a problem with HW2 (I didn't test HW1)
I also got the: "Incorrect. Your submission did not terminate."
but I didn't know why. I'll be checking for tabs next time!
Yes, I got that! A real pain.
happenend to me too, but I'm enjoying the course, I don't care for the gradings anymore... it's a Beta, hope to help udacians find the bugs so if they go on production, they will not have any bugs. :)